Messages in this thread | | | Subject | Re: [PATCH 2.6.23] SysRq: print hotkey info while pressing undef key, try 2 | From | Frans Pop <> | Date | Wed, 17 Oct 2007 18:10:50 +0200 |
| |
Yi Yang wrote: > Hot Key Function Description > ======= ==================== > 0 Changing Loglevel to this value > 1 Changing Loglevel to this value > 2 Changing Loglevel to this value > 3 Changing Loglevel to this value > 4 Changing Loglevel to this value > 5 Changing Loglevel to this value > 6 Changing Loglevel to this value > 7 Changing Loglevel to this value > 8 Changing Loglevel to this value > 9 Changing Loglevel to this value
Wouldn't "Change Loglevel to this value" be more consistent with other descriptions? Or maybe even "Change Kernel Loglevel to <value>"; the repeated "this value" seems somewhat silly.
> b Resetting
This is not very descriptive. Maybe "Immediate System Reboot"?
> c Trigger a crashdump
Most descriptions are capitalized. So for consistency this should be "Trigger a Crashdump". (Although my personal preference would be to drop the capitalization for all descriptions.)
> p Show Regs
Should "Regs" be expanded to "Registers"?
> r Keyboard mode set to XLATE
For consistency: "Set Keyboard Mode to XLATE"
Cheers, Frans Pop - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |