lkml.org 
[lkml]   [2007]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.
    On Tue, 16 Oct 2007 17:41:38 +0200, Willy Tarreau <w@1wt.eu> wrote:

    > OK, I have no objection, but please apply the fixes the le16 problem as
    > suggested by Pete and Greg first. Also, you will probably receive more
    > comments, and/or criticisms from further reviews. This is normal and
    > expected. You just have to fix your code so that it can be merged.

    I do not object to the driver (with byte order fixed), although it seems
    written oddly... E.g. lots of trivial comments, the open count locked
    by wrong lock. But I do not want to hold the 2.4 version hostage to
    errors of the mainline. We should've caught them when we merged adutux
    into Greg's tree. I have to admit I'm skipping reviewing a lot of 2.6.

    -- Pete
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-16 20:01    [W:0.019 / U:30.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site