lkml.org 
[lkml]   [2007]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 03/12] remove dead code in pgtable_cache_init
    The conversion from using a slab cache to quicklist left some residual
    dead code.

    I note that in the conversion it now always allocates a whole page for
    the pgd, rather than the 32 bytes needed for a PAE pgd. Was this
    intended?

    Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
    Cc: Christoph Lameter <clameter@sgi.com>
    Cc: Andi Kleen <ak@suse.de>
    Cc: William Lee Irwin III <wli@holomorphy.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Thomas Gleixner <tglx@linutronix.de>

    ---
    arch/x86/mm/init_32.c | 22 +++++-----------------
    1 file changed, 5 insertions(+), 17 deletions(-)

    ===================================================================
    --- a/arch/x86/mm/init_32.c
    +++ b/arch/x86/mm/init_32.c
    @@ -746,24 +746,12 @@ struct kmem_cache *pmd_cache;

    void __init pgtable_cache_init(void)
    {
    - size_t pgd_size = PTRS_PER_PGD*sizeof(pgd_t);
    -
    - if (PTRS_PER_PMD > 1) {
    + if (PTRS_PER_PMD > 1)
    pmd_cache = kmem_cache_create("pmd",
    - PTRS_PER_PMD*sizeof(pmd_t),
    - PTRS_PER_PMD*sizeof(pmd_t),
    - SLAB_PANIC,
    - pmd_ctor);
    - if (!SHARED_KERNEL_PMD) {
    - /* If we're in PAE mode and have a non-shared
    - kernel pmd, then the pgd size must be a
    - page size. This is because the pgd_list
    - links through the page structure, so there
    - can only be one pgd per page for this to
    - work. */
    - pgd_size = PAGE_SIZE;
    - }
    - }
    + PTRS_PER_PMD*sizeof(pmd_t),
    + PTRS_PER_PMD*sizeof(pmd_t),
    + SLAB_PANIC,
    + pmd_ctor);
    }

    /*
    --

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-15 23:55    [W:0.022 / U:179.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site