Messages in this thread Patch in this message | | | Date | Sun, 14 Oct 2007 19:51:04 +0200 | From | Adrian Bunk <> | Subject | [2.6 patch] e1000e/ethtool.c: fix error checks |
| |
You want to check for the value, not for the address.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
--- --- a/drivers/net/e1000e/ethtool.c +++ b/drivers/net/e1000e/ethtool.c @@ -1451,11 +1451,11 @@ static int e1000_loopback_test(struct e1000_adapter *adapter, u64 *data) } *data = e1000_setup_desc_rings(adapter); - if (data) + if (*data) goto out; *data = e1000_setup_loopback_test(adapter); - if (data) + if (*data) goto err_loopback; *data = e1000_run_loopback_test(adapter); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |