Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] Hook compat_sys_nanosleep up to high res timer code | Date | Mon, 15 Oct 2007 00:28:05 +0200 |
| |
On Sunday 14 October 2007, Anton Blanchard wrote: > Now we have high res timers on ppc64 I thought Id test them. It turns > out compat_sys_nanosleep hasnt been converted to the hrtimer code and so > is limited to HZ resolution. > > The following patch makes compat_sys_nanosleep call hrtimer_nanosleep > and uses compat_alloc_user_space to avoid setting KERNEL_DS. > > Signed-off-by: Anton Blanchard <anton@samba.org>
The code looks correct, but I think it would be nicer to change hrtimer_nanosleep to take a kernel pointer and have all three callers (common_nsleep, sys_nanosleep and compat_sys_nanosleep) do the copy_to_user/put_compat_timespec in the caller.
This would also make it possible to get rid of set_fs() in compat_sys_clock_nanosleep().
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |