lkml.org 
[lkml]   [2007]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: linux-2.6.23-mm1 crashed
    From
    Date
    On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote:
    > On Sun, 14 Oct 2007 22:45:47 +0400 "Dave Milter" <davemilter@gmail.com> wrote:
    >
    > > I build linux-2.6.23-mm1 and try to boot it using qemu,
    > > and it crashed with trace like this:
    > > do_page_fault
    > > error_code
    > > lock_acquire
    > > _spin_lock_irqsave
    > > gdth_timeout
    > > run_timer_softirq
    > > __do_softirq
    > > do_softirq
    > >
    > > I have screenshot, but have no idea, is it legal to include it, if I
    > > sent copy to lkml.
    > > config of kernel in attachment,
    > > I apply all three patches from hot-fixes.
    > >
    >
    > The screenshot is here: http://userweb.kernel.org/~akpm/crash.png
    >
    > It would appear that gdth_timeout() is passing a bad pointer into
    > spin_lock_irqsave().

    There's a bug in the gdth rework in that the instance can be deleted
    from the list before the actual timer is stopped. This can be worked
    around I think by the following patch; although we really should be
    stopping the timer from firing when the list goes empty.

    James

    diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
    index e8010a7..7fa22be 100644
    --- a/drivers/scsi/gdth.c
    +++ b/drivers/scsi/gdth.c
    @@ -3793,6 +3793,9 @@ static void gdth_timeout(ulong data)
    gdth_ha_str *ha;
    ulong flags;

    + if (list_empty(&gdth_instances))
    + return;
    +
    ha = list_first_entry(&gdth_instances, gdth_ha_str, list);
    spin_lock_irqsave(&ha->smp_lock, flags);



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-15 00:29    [W:0.037 / U:0.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site