Messages in this thread | | | Date | Sun, 14 Oct 2007 19:51:59 +0200 | From | Adrian Bunk <> | Subject | tuner-core.c:fe_has_signal() can returne uninitialized value |
| |
Commit 1f5ef19779df2c2f75870332b37dd3004c08a515 added the following function to drivers/media/video/tuner-core.c:
<-- snip -->
static int fe_has_signal(struct tuner *t) { struct dvb_tuner_ops *fe_tuner_ops = &t->fe.ops.tuner_ops; u16 strength;
if (fe_tuner_ops->get_rf_strength) fe_tuner_ops->get_rf_strength(&t->fe, &strength);
return strength; }
<-- snip -->
If (!fe_tuner_ops->get_rf_strength) this function returns the value of an uninitialized variable.
Spotted by the Coverity checker.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |