lkml.org 
[lkml]   [2007]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 2/2] r/o bind mounts: Accept passing a mnt NULL pointer to mnt_drop_write()
    From
    Date
    On Fri, 2007-10-12 at 17:50 +0200, Jan Blunck wrote:
    > In case of somebody opens a file with dentry_open(dentry, NULL, ...) we don't
    > want to stumble on the NULL pointer mnt in struct file.
    ...
    > +++ b/fs/namespace.c
    > @@ -253,6 +253,9 @@ void mnt_drop_write(struct vfsmount *mnt
    > int must_check_underflow = 0;
    > struct mnt_writer *cpu_writer;
    >
    > + if (!mnt)
    > + return;

    I kinda wish we'd fix these in the callers. I know we do something
    similar to this with mntput(), but I worry a bit that this just
    discourages people from using the right interfaces.

    Do you have a case where we're actually getting a NULL mount in here?
    We had at least one in reiser4 that really revealed some nastiness in
    the fs that needed fixing.

    -- Dave

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-12 18:35    [W:0.021 / U:62.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site