lkml.org 
[lkml]   [2007]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] [V3] Replace NT_PRXFPREG with ELF_CORE_XFPREG_TYPE #define
    Replace NT_PRXFPREG with ELF_CORE_XFPREG_TYPE in the coredump code which
    allows for more flexibility in the note type for the state of 'extended
    floating point' implementations in coredumps. New note types can now be
    added with an appropriate #define.

    This does #define ELF_CORE_XFPREG_TYPE to be NT_PRXFPREG in all
    current users so there's are no change in behaviour.

    This will let us use different note types on powerpc for the
    Altivec/VMX state that some PowerPC cpus have (G4, PPC970, POWER6) and
    for the SPE (signal processing extension) state that some embedded
    PowerPC cpus from Freescale have.

    Signed-off-by: Mark Nelson <markn@au1.ibm.com>
    ---
    arch/ia64/ia32/elfcore32.h | 1 +
    arch/x86_64/ia32/ia32_binfmt.c | 1 +
    fs/binfmt_elf.c | 8 ++++----
    fs/binfmt_elf_fdpic.c | 8 ++++----
    include/asm-i386/elf.h | 1 +
    5 files changed, 11 insertions(+), 8 deletions(-)

    Index: linux/arch/ia64/ia32/elfcore32.h
    ===================================================================
    --- linux.orig/arch/ia64/ia32/elfcore32.h
    +++ linux/arch/ia64/ia32/elfcore32.h
    @@ -117,6 +117,7 @@ elf_core_copy_task_fpregs(struct task_st
    }

    #define ELF_CORE_COPY_XFPREGS 1
    +#define ELF_CORE_XFPREG_TYPE NT_PRXFPREG
    static inline int
    elf_core_copy_task_xfpregs(struct task_struct *tsk, elf_fpxregset_t *xfpu)
    {
    Index: linux/arch/x86_64/ia32/ia32_binfmt.c
    ===================================================================
    --- linux.orig/arch/x86_64/ia32/ia32_binfmt.c
    +++ linux/arch/x86_64/ia32/ia32_binfmt.c
    @@ -188,6 +188,7 @@ elf_core_copy_task_fpregs(struct task_st
    }

    #define ELF_CORE_COPY_XFPREGS 1
    +#define ELF_CORE_XFPREG_TYPE NT_PRXFPREG
    static inline int
    elf_core_copy_task_xfpregs(struct task_struct *t, elf_fpxregset_t *xfpu)
    {
    Index: linux/fs/binfmt_elf.c
    ===================================================================
    --- linux.orig/fs/binfmt_elf.c
    +++ linux/fs/binfmt_elf.c
    @@ -1411,7 +1411,7 @@ struct elf_thread_status
    elf_fpregset_t fpu; /* NT_PRFPREG */
    struct task_struct *thread;
    #ifdef ELF_CORE_COPY_XFPREGS
    - elf_fpxregset_t xfpu; /* NT_PRXFPREG */
    + elf_fpxregset_t xfpu; /* ELF_CORE_XFPREG_TYPE */
    #endif
    struct memelfnote notes[3];
    int num_notes;
    @@ -1446,8 +1446,8 @@ static int elf_dump_thread_status(long s

    #ifdef ELF_CORE_COPY_XFPREGS
    if (elf_core_copy_task_xfpregs(p, &t->xfpu)) {
    - fill_note(&t->notes[2], "LINUX", NT_PRXFPREG, sizeof(t->xfpu),
    - &t->xfpu);
    + fill_note(&t->notes[2], "LINUX", ELF_CORE_XFPREG_TYPE,
    + sizeof(t->xfpu), &t->xfpu);
    t->num_notes++;
    sz += notesize(&t->notes[2]);
    }
    @@ -1624,7 +1624,7 @@ static int elf_core_dump(long signr, str
    #ifdef ELF_CORE_COPY_XFPREGS
    if (elf_core_copy_task_xfpregs(current, xfpu))
    fill_note(notes + numnote++,
    - "LINUX", NT_PRXFPREG, sizeof(*xfpu), xfpu);
    + "LINUX", ELF_CORE_XFPREG_TYPE, sizeof(*xfpu), xfpu);
    #endif

    fs = get_fs();
    Index: linux/fs/binfmt_elf_fdpic.c
    ===================================================================
    --- linux.orig/fs/binfmt_elf_fdpic.c
    +++ linux/fs/binfmt_elf_fdpic.c
    @@ -1417,7 +1417,7 @@ struct elf_thread_status
    elf_fpregset_t fpu; /* NT_PRFPREG */
    struct task_struct *thread;
    #ifdef ELF_CORE_COPY_XFPREGS
    - elf_fpxregset_t xfpu; /* NT_PRXFPREG */
    + elf_fpxregset_t xfpu; /* ELF_CORE_XFPREG_TYPE */
    #endif
    struct memelfnote notes[3];
    int num_notes;
    @@ -1453,8 +1453,8 @@ static int elf_dump_thread_status(long s

    #ifdef ELF_CORE_COPY_XFPREGS
    if (elf_core_copy_task_xfpregs(p, &t->xfpu)) {
    - fill_note(&t->notes[2], "LINUX", NT_PRXFPREG, sizeof(t->xfpu),
    - &t->xfpu);
    + fill_note(&t->notes[2], "LINUX", ELF_CORE_XFPREG_TYPE,
    + sizeof(t->xfpu), &t->xfpu);
    t->num_notes++;
    sz += notesize(&t->notes[2]);
    }
    @@ -1690,7 +1690,7 @@ static int elf_fdpic_core_dump(long sign
    #ifdef ELF_CORE_COPY_XFPREGS
    if (elf_core_copy_task_xfpregs(current, xfpu))
    fill_note(notes + numnote++,
    - "LINUX", NT_PRXFPREG, sizeof(*xfpu), xfpu);
    + "LINUX", ELF_CORE_XFPREG_TYPE, sizeof(*xfpu), xfpu);
    #endif

    fs = get_fs();
    Index: linux/include/asm-i386/elf.h
    ===================================================================
    --- linux.orig/include/asm-i386/elf.h
    +++ linux/include/asm-i386/elf.h
    @@ -129,6 +129,7 @@ extern int dump_task_extended_fpu (struc
    #define ELF_CORE_COPY_TASK_REGS(tsk, elf_regs) dump_task_regs(tsk, elf_regs)
    #define ELF_CORE_COPY_FPREGS(tsk, elf_fpregs) dump_task_fpu(tsk, elf_fpregs)
    #define ELF_CORE_COPY_XFPREGS(tsk, elf_xfpregs) dump_task_extended_fpu(tsk, elf_xfpregs)
    +#define ELF_CORE_XFPREG_TYPE NT_PRXFPREG

    #define VDSO_HIGH_BASE (__fix_to_virt(FIX_VDSO))
    #define VDSO_CURRENT_BASE ((unsigned long)current->mm->context.vdso)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-12 04:43    [W:0.038 / U:90.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site