lkml.org 
[lkml]   [2007]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] x86: mce init optimization and signedness fixup
    > So when I change the above code snippet to:
    >
    > + if (!cpu_has(c, X86_FEATURE_MCE)) {
    > + printk(KERN_INFO "CPU%i: No machine check support available\n",
    > + smp_processor_id());
    > + return;
    >
    > Would this make the whole patch acceptable then?

    I think the fundamental direction is wrong. "Do you have a machine check
    like facility" is a CPU specific question that belongs in the CPU
    specific code.

    If some of that CPU specific code is wrong, fix it there.

    Alan
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-11 21:53    [W:0.023 / U:0.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site