lkml.org 
[lkml]   [2007]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] powerpc: don't enable cpu hotplug on mpic-based pseries
    On Thu, Oct 11, 2007 at 03:52:04PM +1000, Paul Mackerras wrote:
    > Olof Johansson writes:
    >
    > > Don't allow cpu hotplug on systems lacking XICS interrupt controller,
    > > since current code is hardcoded for it.
    > ...
    > > + for (np = NULL; (np = of_find_node_by_name(np,
    > > + "interrupt-controller"));) {
    >
    > Looks like for_each_node_by_name would be nicer here.
    >
    > If you agree, I'll hand-edit your patch to do that and apply it.

    Go for it, I just stole that out of the detection code. That
    could be changed accordingly as well at some point (I'm guessing
    for_each_node_by_name didn't exist when that was written).

    > Of course, ultimately we should implement the necessary mpic bits to
    > support cpu hotplug.

    Yep. I'll leave that to people who have hardware access. :-)


    Thanks,

    -Olof
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-11 07:57    [W:2.871 / U:2.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site