lkml.org 
[lkml]   [2007]   [Oct]   [1]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    DateMon, 01 Oct 2007 09:48:25 +0200
    FromAvi Kivity <>
    SubjectRe: checkpatch and kernel/sched.c
    Andrew Morton wrote:
    >> this is actually a false positive - as the debug code constructs a 
    >> printk output _without_ \n. So the script should check whether there's 
    >> any \n in the printk string - if there is none, do not emit a warning. 
    >> (if you implement that then i think it can remain a warning and does not 
    >> need to move to CHECK.)
    >> 
    >
    > Yeah, it does that sometimes.  I don't think it's fixable within the scope
    > of checkpatch.  It needs to check whether some preceding printk which might
    > not even be in the patch has a \n:
    >
    > 	printk(KERN_ERR "foo");
    > 	<100 lines of whatever>
    > +	printk("bar\n");
    >
    > we're screwed...
    >
    > 
    
    Isn't that broken on SMP (or with preemption) anyway?
    
    -- 
    Do not meddle in the internals of kernels, for they are subtle and quick to panic.
    
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2007-10-01 09:35    [from the cache]
    ©2003-2008