[lkml]   [2007]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: checkpatch and kernel/sched.c
Andrew Morton wrote:
>> this is actually a false positive - as the debug code constructs a
>> printk output _without_ \n. So the script should check whether there's
>> any \n in the printk string - if there is none, do not emit a warning.
>> (if you implement that then i think it can remain a warning and does not
>> need to move to CHECK.)
> Yeah, it does that sometimes. I don't think it's fixable within the scope
> of checkpatch. It needs to check whether some preceding printk which might
> not even be in the patch has a \n:
> printk(KERN_ERR "foo");
> <100 lines of whatever>
> + printk("bar\n");
> we're screwed...

Isn't that broken on SMP (or with preemption) anyway?

Do not meddle in the internals of kernels, for they are subtle and quick to panic.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-10-01 09:35    [W:0.144 / U:11.312 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site