[lkml]   [2007]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class
    On Mon, Oct 01, 2007 at 09:25:46AM -0700, Greg KH wrote:
    > I'll defer to Jeff's judgement here. If the device is broken such that
    > it does not know to return the correct class, then we need to be able to
    > have a "quirk" table in the userspace tools to handle the list of
    > devices that are broken in that way.

    I think Jeff is right on this particular point -- better to have this
    worked around in the userspace tool than in the kernel.

    > For config items, we don't want to modify them in any way, we just want
    > to pass-through the data direct from the device. Look at the sysfs and
    > proc files for pci config spaces. They are returning binary data stored
    > in the device directly. We do not want to have to start modifying that
    > data directly just to handle messed up devices like this.

    Nobody's talking about changing the raw pci data. What we're talking
    about is changing the value read out of

    $ cat /sys/bus/pci/devices/0000\:00\:00.0/class

    We do tweak at least some of the other similar values (vendor, for sure)
    to work around bugs; not sure we have an example for changing the class
    value yet.

    pciutils knows that the kernel has potentially fixed up the values in
    the individual files, and to trust those over the raw data.

    Intel are signing my paycheques ... these opinions are still mine
    "Bill, look, we understand that you're interested in selling us this
    operating system, but compare it to ours. We can't possibly take such
    a retrograde step."
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-10-01 19:07    [W:0.020 / U:19.184 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site