Messages in this thread | | | Date | Mon, 1 Oct 2007 10:46:38 -0600 | From | "Grant Likely" <> | Subject | Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding |
| |
On 10/1/07, Akinobu Mita <akinobu.mita@gmail.com> wrote: > 2007/10/2, Grant Likely <grant.likely@secretlab.ca>: > > > static int __init > > xilinxfb_init(void) > > { > > - /* > > - * No kernel boot options used, > > - * so we just need to register the driver > > - */ > > + int rc; > > + rc = xilinxfb_of_register(); > > + if (rc) > > + return rc; > > + > > return platform_driver_register(&xilinxfb_platform_driver); > > Is it better to add error handling for platform_driver_register()?
Right, good catch. I'll fix that
Thanks! g.
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |