Messages in this thread | | | Date | Mon, 1 Oct 2007 13:59:54 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH v2 2/6] Sysace: Use the established platform bus api |
| |
On Sun, Sep 30 2007, Grant Likely wrote: > On 9/30/07, Christoph Hellwig <hch@infradead.org> wrote: > > On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: > > > + if ((rc = platform_driver_register(&ace_platform_driver)) != 0) > > > + goto err_plat; > > > > rc = platform_driver_register(&ace_platform_driver); > > if (rc) > > goto err_plat; > > > > please. > > Okay, will do. > > > > > > + err_plat: > > > + unregister_blkdev(ace_major, "xsysace"); > > > + err_blk: > > > > labels should be indented zero or one space, but not more. > > scripts/Lindent does this. Originally, I *didn't* have my labels > indented. :-) Does Lindent need to be fixed?
Seems so, if it idents labels.
Just send a fixup patch for that, I'll add your series to the block tree for 2.6.24.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |