lkml.org 
[lkml]   [2007]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] sata_sis: Support for PATA supports
    Alan wrote:
    > This is quick rework of the patch Uwe proposed but using Kconfig not
    > ifdefs and user selection to sort out PATA support. Instead of ifdefs and
    > requiring the user to select both drivers the SATA driver selects the
    > PATA one.
    >
    > For neatness I've also moved the extern into the function that uses it.
    >
    > Two questions really
    > 1. Do you want the extern in a header file
    > 2. Is this now neat enough to keep you happy Jeff or shall I do
    > the library split anyway ?
    >
    > Please let me know so I can fire off new versions and try and get
    > this one submitted for good today.
    >
    > Signed-off-by: Alan Cox

    I ACK this patch, as mentioned earlier, but the description and sign-off
    leave something to be desired.

    Would you rather resend this patch without all the commentary, so that
    it may be automatically snarfed, or just resend a proper description and
    sign-off?

    Note that (as stated in Documentation/SubmittingPatches) the standard
    way to include commentary is to include it after the patch description
    and "---" separator. Anything after "---" is automatically snipped.

    This applies to patches sent to Linus, me, and anyone else who uses git
    to import patches. (as well as being the patch format standard)

    Jeff



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-09 12:47    [W:0.030 / U:29.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site