lkml.org 
[lkml]   [2007]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT
On Tue, 9 Jan 2007 12:01:21 +0100
Andi Kleen <ak@suse.de> wrote:

> On Tuesday 09 January 2007 03:55, Adrian Bunk wrote:
> > RESTORE_CONTEXT lost a newline in
> > commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9:
> > http://www.mail-archive.com/kgdb-bugreport@lists.sourceforge.net/msg00559.html
>
> I don't think we should add such changes for external patchkits.
>
> In general kgdb shouldn't add any patches at all. If the existing
> hooks are not enough they should submit their changes needed so
> that it can just work.
>

But the patch is a bugfix. Without it, you cannot do

RESTORE_CONTEXT \
.globl ... \

Was the addition of this restriction to RESTORE_CONTEXT deliberate, or
mistaken?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-09 23:33    [from the cache]
©2003-2011 Jasper Spaans