lkml.org 
[lkml]   [2007]   [Jan]   [8]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
FromArnd Bergmann <>
SubjectRe: [PATCH] Common compat_sys_sysinfo (v2)
DateMon, 8 Jan 2007 06:54:26 +0100
On Monday 08 January 2007 00:43, Stephen Rothwell wrote:
> > +asmlinkage long sys_sysinfo(struct sysinfo __user *info)
> > +{
> > +     struct sysinfo val;
> > +
> > +     do_sysinfo(&val);
> >
> > - out:
> >       if (copy_to_user(info, &val, sizeof(struct sysinfo)))
> >               return -EFAULT;
> 
> People have complined before that this adds a whole stack frame to the
> "normal" syscall path.  Personally I don't care, but it has been
> mentioned.

It might be a concern for something like 'read' which is called frequently
and in strange ways, but for 'sysinfo' this really should not matter.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-08 08:27    [from the cache]
©2003-2008