Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH] update MMConfig patches w/915 support | Date | Mon, 8 Jan 2007 13:22:46 -0800 |
| |
On Monday, January 8, 2007 12:32 pm, Olivier Galibert wrote: > > The routines could probably be consolidated into a single > > probe_intel_9xx routine or something, but I really looked at that > > yet (though there are many similarities between the 91[05], 945 and > > 965 families, they may not be enough that the code would actually > > be simpler if shared. > > The individual functions are so simple, it's probably way better for > maintainance simplicity to keep them separate, at least for now.
Yeah, sounds good.
> > + pci_conf1_read(0, 0, PCI_DEVFN(0,0), 0x48, 4, &pciexbar); > > + > > + /* No enable bit or size field, so assume 256M range is enabled. > > */ + len = 0x10000000U; > > + pci_mmcfg_config_num = 1; > > + > > + pci_mmcfg_config = kzalloc(sizeof(pci_mmcfg_config[0]), > > GFP_KERNEL); + pci_mmcfg_config[0].base_address = pciexbar; > > Hmmm, I'd mask out the reserved bits if I were you. Paranoia :-)
Wouldn't hurt I suppose, want me to post a new patch?
Thanks, Jesse - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |