lkml.org 
[lkml]   [2007]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    On 01/07, Oleg Nesterov wrote:
    >
    > How about:
    >
    > CPU_DEAD does nothing. After __cpu_disable() cwq->thread runs on
    > all CPUs and becomes idle when it flushes cwq->worklist: nobody
    > will add work_struct on that list.

    Also, we can add cpu_workqueue_struct->should_exit_after_flush flag, but
    we have to be careful to serialize with destroy_workqueue/CPU_UP.

    > CPU_UP:
    > if (!cwq->thread)
    > create_workqueue_thread();
    > else
    > set_cpus_allowed(newcpu);
    >
    > flush_workqueue:
    > for_each_possible_cpu() // NOT online!
    > if (cwq->thread)
    > flush_cpu_workqueue()

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-07 15:45    [W:0.022 / U:89.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site