Messages in this thread | | | Date | Sun, 07 Jan 2007 20:46:13 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH libata #promise-sata-pata] sata_promise: unbreak 20619 |
| |
Mikael Pettersson wrote: > The PATA support patch for sata_promise appears, from > code inspection, to break the PATA-only 20619 chip. > > The patch removes the SATA flag from the TX2plus SATA+PATA > boards' common flags, with the intention of adding it back > via the _port_flags[] entries for those boards' SATA ports. > > However, it unconditionally marks ports 0 and 1 as SATA > for all boards. This causes the 20619 (TX4000) to announce > its first two PATA ports as SATA | ATA_FLAG_SLAVE_POSS. > > I don't have a TX4000 so I don't know what the actual > consequences of this bug are, but surely this isn't Ok. > > Fixed by moving the port 0 and 1 settings as SATA into > the TX4 and TX2plus specific initialisation code. > > Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Given that I agree with your RFC, this means I can drop all these #promise-sata-pata patches, and kill the #promise-sata-pata branch soon, right?
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |