Messages in this thread | | | Subject | Re: [patch] paravirt: isolate module ops | From | Rusty Russell <> | Date | Sun, 07 Jan 2007 12:09:56 +1100 |
| |
On Sat, 2007-01-06 at 12:55 -0800, Zachary Amsden wrote: > Rusty Russell wrote: > > > > +int paravirt_write_msr(unsigned int msr, u64 val); > > If binary modules using debug registers makes us nervous, the > reprogramming MSRs is also similarly bad.
Yes, but this is simply from experience. Several modules wrote msrs (you can take out the EXPORT_SYMBOL and find them quite quickly).
> > +void raw_safe_halt(void); > > +void halt(void); > > These shouldn't be done by modules, ever. Only the scheduler should > decide to halt.
Several modules implement alternate halt loops. I guess being in a module for specific CPUs makes sense...
Cheers! Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |