[lkml]   [2007]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 4/4] Add MMC Password Protection (lock/unlock) support V9: mmc_sysfs.diff
    I've queued it up for -mm, but there a few more comments I want resolved
    before this can move to Linus...

    You need to clean up mmc_lockable_store(). It had a few broken variable
    declarations that even prevented it from compiling, and after I fixed
    that I still get:

    drivers/mmc/mmc_sysfs.c: In function ‘mmc_lockable_store’:
    drivers/mmc/mmc_sysfs.c:160: warning: ignoring return value of
    ‘device_attach’, declared with attribute warn_unused_result
    drivers/mmc/mmc_sysfs.c:93: warning: ‘mmc_key’ may be used uninitialized
    in this function

    There's also no handling for an invalid string written to the sysfs node.

    And third, you're a bit excessive on the goto:s. E.g. out_unlocked is
    used in a single place, so it is completely unnecessary. Please do a
    general cleanup of the control flow.


    -- Pierre Ossman

    Linux kernel, MMC maintainer
    PulseAudio, core developer
    rdesktop, core developer

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-01-06 23:27    [W:0.038 / U:19.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site