Messages in this thread | | | Date | Fri, 5 Jan 2007 11:51:09 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH 2.6.20-rc3] qconf Search Dialog |
| |
On Fri, 5 Jan 2007 12:44:13 +0200 Shlomi Fish wrote:
> On Wednesday 03 January 2007 23:05, Sam Ravnborg wrote: > > On Wed, Jan 03, 2007 at 10:01:28PM +0200, Shlomi Fish wrote: > > > Interesting. I didn't notice this search dialog before because its menu > > > item was placed in the "File" menu, which is the wrong place for a find > > > command (Which should be in an "Edit" or "Search" menu). I believe others > > > have missed it as well. Also, it is possible it wasn't available when I > > > wrote the preliminary version of the patch back in March. > > > > > > Aside from that my search dialog has some advantages: > > > > > > 1. Full text search - if you search for "available" in File->Search you > > > won't find anything. Searching for it in Edit->Find will find many > > > things. I think File->Search only searches using the identifiers or at > > > most also the title. > > > > > > 2. Regular expression search. > > > > > > 3. Displaying the results in a tree, with their context. > > > > > > All that said, I don't mind merging my modifications into the existing > > > code, or replacing it entirely. > > > > Please merge the best of the existing and the new search dialog. > > > > OK. > > > I would prefer it as separate smaller steps. > > So one patch where you move the dialog and another where you improve > > the search dialog. > > > > Move the dialog from where, to where, and in what respect?
From where it currently is in mainline (File/Find) to where your patch puts it (Edit/Find). And then "fix" the Find function in a separate patch.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |