lkml.org 
[lkml]   [2007]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.20-rc6-mm3
    Tilman Schmidt wrote:
    > On Tue, 30 Jan 2007 17:25:25 -0800, Andrew Morton wrote:
    >
    >> On Wed, 31 Jan 2007 02:16:43 +0100
    >> Tilman Schmidt <tilman@imap.cc> wrote:
    >>
    >>
    >>> Am 30.01.2007 23:18 schrieb Maciej Rutecki:
    >>>
    >>>> Second problem, power button doesn't work. When I pressed it, I has this
    >>>> error:
    >>>>
    >>>> ACPI Error (evevent-0305): No installed handler for fixed event
    >>>> [00000002] [20070126]
    >>>>
    >>> Same here, minus the message. (Or perhaps I just don't know where to look.)
    >>> Problem also exists in 2.6.20-rc6-mm2. With 2.6.20-rc6-git1 the power
    >>> button of this machine works fine.
    >>>
    >> That's significant - in your case at least the 2.6.20-rc6-mm3 ACPI update
    >> isn't the cause.
    >>
    >
    > Is there anything specific I should test, or Big Bisect time?
    >
    >
    This patch should fix the issue...

    Regards,
    Alex.
    Correct id for fixed buttons.
    ACPI_BUTTON_HID_POWERF was changed, but this change was not propogated to button.c,
    thus breaking detection of fixed power and sleep buttons.
    From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>


    ---

    drivers/acpi/button.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
    index ac86058..c726612 100644
    --- a/drivers/acpi/button.c
    +++ b/drivers/acpi/button.c
    @@ -75,7 +75,7 @@ static int acpi_button_state_open_fs(str
    static struct acpi_driver acpi_button_driver = {
    .name = ACPI_BUTTON_DRIVER_NAME,
    .class = ACPI_BUTTON_CLASS,
    - .ids = "ACPI_FPB,ACPI_FSB,PNP0C0D,PNP0C0C,PNP0C0E",
    + .ids = "button_power,button_sleep,PNP0C0D,PNP0C0C,PNP0C0E",
    .ops = {
    .add = acpi_button_add,
    .remove = acpi_button_remove,
    \
     
     \ /
      Last update: 2007-01-31 13:33    [W:0.022 / U:1.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site