lkml.org 
[lkml]   [2007]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/23] clocksource: add clocksource_get_clock()

* Daniel Walker <dwalker@mvista.com> wrote:

> One new API call clocksource_get_clock() which allows clocks to be
> selected based on their name, or if the name is null the highest rated
> clock is returned.

this one (and the dependent APIs utilizations) look a step in the right
direction to me, but they are not fully consequent and thus a bit
confusing at the moment:

- the current_clocksource is now something that is conceptually related
to timekeeping - while it still resides in the clocksource domain.

- if we do this split there should be a separate sysfs hierarchy for
timekeeping, separate of clocksource

- you use struct sys_device clocksource_sys_device from clocksource.c in
timekeeping.c, which is inconsistent as well.

so these bits need more work.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-31 12:51    [from the cache]
©2003-2011 Jasper Spaans