[lkml]   [2007]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 08/23] clocksource: drop duplicate register checking

* Daniel Walker <> wrote:

> This is something Thomas already dropped, [...]

(i think you forgot to Cc: Thomas here, nor is this something that
Thomas' change dropped.)

> [...] and I'm just sticking with that .. If you register your
> clocksource _twice_ your kernel will likely not work correctly (and
> might crash).

this is a quite bad change. John's original clocksource code protects
against double registry:

if (is_registered_source(c)) {
printk("register_clocksource: Cannot register %s. "
"Already registered!", c->name);
ret = -EBUSY;

and Thomas' change keeps that property, but doesnt printk. Your change
makes double registry possible, potentially crashing the kernel later
on! (And this isnt theoretical, double registry did happen in practice
when i debugged suspend problems on my SMP laptop.)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-01-31 11:03    [from the cache]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site