lkml.org 
[lkml]   [2007]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 23/23] clocksource tsc: add verify routine
    From
    Date
    On Wed, 2007-01-31 at 09:02 -0800, Daniel Walker wrote:
    > > well, this implementation is buggy in at least two ways:
    > >
    > > firstly, it allows a circular verification dependency in highres+dyntick
    > > mode between the jiffies and tsc clocksources.
    >
    > In the current implementation, it's only happens if the only clocks that
    > exist are "tsc" and "jiffies" which makes verification impossible
    > anyway .. It's unlikely, but it is possible , the fix is not that
    > complex.

    Wrong. You actually can verify against jiffies. Johns orginal code did
    this and mine does too. Actually this _IS_ necessary otherwise you can
    not detect that the BIOS changed the cpu freqeuncy behind the kernels
    back.

    The circular problem is only relevant when you switch to highres/nohz.

    tglx


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-31 18:27    [W:0.022 / U:0.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site