lkml.org 
[lkml]   [2007]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/23] clocksource: drop duplicate register checking

* Daniel Walker <dwalker@mvista.com> wrote:

> > if (is_registered_source(c)) {
> > printk("register_clocksource: Cannot register %s. "
> > "Already registered!", c->name);
> > ret = -EBUSY;
> >
> > and Thomas' change keeps that property, but doesnt printk. Your
> > change makes double registry possible, potentially crashing the
> > kernel later on! (And this isnt theoretical, double registry did
> > happen in practice when i debugged suspend problems on my SMP
> > laptop.)
>
> My original patch set makes the duplicate register checking better
> (which I dropped) .. I'll be happy to reintroduce that part of it..

why if Thomas' patch: simplify-the-registration-of-clocksources.patch
already does it?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-31 18:25    [W:0.046 / U:0.500 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site