lkml.org 
[lkml]   [2007]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Cbe-oss-dev] [RFC, PATCH 4/4] Add support to OProfile for profiling Cell BE SPUs -- update
    From
    Date

    > > +/* Defines used for sync_start */
    > > +#define SKIP_GENERIC_SYNC 0
    > > +#define SYNC_START_ERROR -1
    > > +#define DO_GENERIC_SYNC 1
    > > +
    > > +typedef struct vma_map
    > > +{
    > > + struct vma_map *next;
    > > + unsigned int vma;
    > > + unsigned int size;
    > > + unsigned int offset;
    > > + unsigned int guard_ptr;
    > > + unsigned int guard_val;
    > > +} vma_map_t;

    I haven't had time to look in details yet but in that context, what does
    "vma" stands for ? There's already an important vm data structure in
    linux routinely called "vma" and thus I suspect this is a poor naming
    choice as it will cause confusion.

    Cheers,
    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-30 08:59    [W:0.019 / U:63.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site