lkml.org 
[lkml]   [2007]   [Jan]   [30]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
FromKumar Gala <>
SubjectRe: [PATCH] kprobes: Fix compiler warning
DateTue, 30 Jan 2007 01:12:17 -0600
On Jan 30, 2007, at 1:05 AM, Kumar Gala wrote:

>
> On Jan 29, 2007, at 11:55 PM, Ananth N Mavinakayanahalli wrote:
>
>> On Mon, Jan 29, 2007 at 11:43:33PM -0600, Kumar Gala wrote:
>>> On ppc the compiler gripes about:
>>>
>>> kernel/kprobes.c: In function 'collect_garbage_slots':
>>> kernel/kprobes.c:215: warning: comparison is always false due to  
>>> limited
>>> range of data type
>>>
>>> The compiler ends up optimizing away the test since char's are  
>>> unsigned on
>>> ppc.
>>
>> Kumar,
>>
>> Masami fixed this last week:
>>
>> http://marc.theaimsgroup.com/?l=linux-kernel&m=116968723823366&w=2
>>
>> Patch currently in -mm.
>>
>> Thanks,
>> Ananth
>
> Cool, Masami's patch looks far more complete.

Andrew,

What are your thoughts on forward Masami patch to Linus for 2.6.20  
since it fixes a real bug on PPC?

- k
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-30 08:15    [from the cache]
©2003-2008