lkml.org 
[lkml]   [2007]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/7] fs: break the file_list_lock for sb->s_files
FromPeter Zijlstra <>
DateSun, 28 Jan 2007 16:32:43 +0100
On Sun, 2007-01-28 at 15:30 +0000, Christoph Hellwig wrote:
> On Sun, Jan 28, 2007 at 04:21:06PM +0100, Ingo Molnar wrote:
> > > > sb->s_files is converted to a lock_list. furthermore to prevent the
> > > > lock_list_head of getting too contended with concurrent add
> > > > operations the add is buffered in per cpu filevecs.
> > > NACK. Please don't start using lockdep internals in core code.
> >
> > what do you mean by that?
>
> struct lock_list is an lockdep implementation detail and should not
> leak out and be used anywhere else. If we want something similar it
> should be given a proper name and a header of it's own, but I don't
> think it's a valueable abstraction for the core kernel.

please see patch 2/7, its unrelated to lockdep internals.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-28 16:35    [from the cache]
©2003-2010