lkml.org 
[lkml]   [2007]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/26] Dynamic kernel command-line - ia64
    On 1/27/07, Andrew Morton <akpm@osdl.org> wrote:
    > no no no no no no no. Just because some whacked-out weenie went and put
    > extern declarations in .c files doesn't mean that we should copy them.
    >
    > It doesn't even compile.

    Sorry... I don't have all environments.

    > Please. Go through the entire patchset, yank all those wrong private
    > declarations of boot_command_line[] and put a *single, kernel-wide*
    > declaration into a single, shared header file.

    I thought of this, while I was making the patch, I could not understand why
    the maintainer did not simply #include <linux/init.h>

    I can add this to any module which declares this by-itself but because
    I cannot test all arch, I am afraid it will cause more problems.

    Preparing a patch... :)

    Best Regards,
    Alon Bar-Lev.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-27 09:37    [W:0.019 / U:1.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site