lkml.org 
[lkml]   [2007]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/26] Dynamic kernel command-line - ia64
    On Tue, 23 Jan 2007 00:14:06 +0200
    Alon Bar-Lev <alon.barlev@gmail.com> wrote:

    >
    > 1. Rename saved_command_line into boot_command_line.
    > 2. Set command_line as __initdata.
    >
    > Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
    >
    > ---
    >
    > diff -urNp linux-2.6.20-rc4-mm1.org/arch/ia64/kernel/efi.c linux-2.6.20-rc4-mm1/arch/ia64/kernel/efi.c
    > --- linux-2.6.20-rc4-mm1.org/arch/ia64/kernel/efi.c 2007-01-07 07:45:51.000000000 +0200
    > +++ linux-2.6.20-rc4-mm1/arch/ia64/kernel/efi.c 2007-01-22 23:32:30.000000000 +0200
    > @@ -413,11 +413,11 @@ efi_init (void)
    > efi_char16_t *c16;
    > u64 efi_desc_size;
    > char *cp, vendor[100] = "unknown";
    > - extern char saved_command_line[];
    > + extern char __initdata boot_command_line[];
    > int i;
    >
    > chk_nointroute_opt(void)
    > {
    > char *cp;
    > - extern char saved_command_line[];
    > + extern char __initdata boot_command_line[];

    no no no no no no no. Just because some whacked-out weenie went and put
    extern declarations in .c files doesn't mean that we should copy them.

    It doesn't even compile.

    arch/ia64/kernel/efi.c: In function `efi_init':
    arch/ia64/kernel/efi.c:416: error: section attribute cannot be specified for local variables

    Please. Go through the entire patchset, yank all those wrong private
    declarations of boot_command_line[] and put a *single, kernel-wide*
    declaration into a single, shared header file.

    Thanks.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-27 09:29    [W:0.024 / U:31.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site