lkml.org 
[lkml]   [2007]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix /sys/device/.../power/state regression
On Fri, Jan 26, 2007 at 11:59:05AM -0800, Andrew Morton wrote:
> On Thu, 25 Jan 2007 05:00:09 +0000
> Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>
> > In 2.6.19, support for splitting driver suspend and resume callbacks
> > into interrupt and non-interrupt contexts was added. Unfortunately, this
> > broke /sys/device/.../power/state support for all devices. In the long
> > run, this should be obsoleted by power management support in the
> > individual drivers - however, in the case of network drivers (for
> > example), currently only three drivers implement any sort of useful
> > run-time power management.
> >
> > This patch allows the bus driver to check whether a specific driver
> > requires the split. If not, the 2.6.18 functionality is restored. It
> > also alters feature-removals.txt to note that the deprecated
> > functionality should not be removed until a replacement actually exists.
>
> That sounds like material for 2.6.20 as well as for 2.6.19.x.

No, it's not stable material, as drivers would have to be modified to
support it, and that is adding new stuff. See my other comment about
why this was changed because it was broken...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-26 21:45    [from the cache]
©2003-2011 Jasper Spaans