Messages in this thread | | | Date | Fri, 26 Jan 2007 20:53:21 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] fix OCFS2 compile error |
| |
On Fri, Jan 26, 2007 at 11:47:13AM -0800, Mark Fasheh wrote: > On Fri, Jan 26, 2007 at 07:49:42PM +0100, Adrian Bunk wrote: > > I don't know why gcc 3.3 generates this now since ocfs2_backup_super_blkno() > > seems to be unused, but there is a bug for 32 bit systems that should be > > fixed: > > > > Commit 50af94b14c98f5769860a282a397c6f3b135c8a8 adds: > > offset /= sb->s_blocksize; > > > > That is: > > u64 = u64 / long > > > > Not a problem on 64bit architectures, but obviously a problem on 32 bit > > architectures. > > > > This patch fixes it by using sb->s_blocksize_bits instead of sb->s_blocksize. > > Thanks Adrian... I think we both hit upon this at about the same time :) My > patch made it into ocfs2.git first (for obvious reasons)...
That's unfair. ;-)
> --Mark
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |