![]() | |||||||||||||
Messages in this thread |
Randy Dunlap wrote:
> On Tue, 16 Jan 2007 07:15:20 +0100 Nadia.Derbey@bull.net wrote:
>
>
>>[PATCH 04/06]
>>
>>Introduces the kobjects associated to each tunable min and max value
>>
<snip>
>>Index: linux-2.6.20-rc4/kernel/autotune/akt.c
>>===================================================================
>>--- linux-2.6.20-rc4.orig/kernel/autotune/akt.c 2007-01-15 15:13:31.000000000 +0100
>>+++ linux-2.6.20-rc4/kernel/autotune/akt.c 2007-01-15 15:25:35.000000000 +0100
>>@@ -203,5 +207,121 @@ ssize_t store_tuning_mode(struct auto_tu
>> }
>>
>>
<snip>
>>+
>>+/*
>>+ * FUNCTION: Set operation called by tunable_attr_store (i.e. when a
>>+ * string is stored into /sys/tunables/<tunable>/min).
>>+ *
>>+ * PARAMETERS: count: input buffer size (including the '\0')
>>+ *
>>+ * RETURN VALUE: >0: number of characters used from the input buffer
>>+ * <= 0: failure
>
>
> I would expect a return value of 0 not to indicate failure;
> only <0 should do that. So is this a typo or a real case where
> a return of 0 indicates failure?
This is a typo
>
>
>>+ */
>>+ssize_t store_tunable_min(struct auto_tune *tun_addr, const char *buf,
>>+ size_t count)
>>+{
<snip>
>>+/*
>>+ * FUNCTION: Set operation called by tunable_attr_store (i.e. when a
>>+ * string is stored into /sys/tunables/<tunable>/max).
>>+ *
>>+ * PARAMETERS: count: input buffer size (including the '\0')
>>+ *
>>+ * RETURN VALUE: >0: number of characters used from the input buffer
>>+ * <= 0: failure
>
>
> same question.
Same answer ;-)
>
>
Regards,
Nadia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
| ||||||||||||
| Last update: 2007-01-25 17:35 [from the cache] ©2003-2008 | |||||||||||||