lkml.org 
[lkml]   [2007]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Fix race in efi variable delete code.
    Fix race when deleting an EFI variable and issuing another EFI command on the
    same variable. The removal of the variable from the efivars_list should be
    done in efivar_delete and not delayed until the kprobes release.

    Signed-off-by: Prarit Bhargava <prarit@redhat.com>

    diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
    index 5ab5e39..bf2ca97 100644
    --- a/drivers/firmware/efivars.c
    +++ b/drivers/firmware/efivars.c
    @@ -385,10 +385,8 @@ static struct sysfs_ops efivar_attr_ops = {

    static void efivar_release(struct kobject *kobj)
    {
    - struct efivar_entry *var = container_of(kobj, struct efivar_entry, kobj);
    - spin_lock(&efivars_lock);
    - list_del(&var->list);
    - spin_unlock(&efivars_lock);
    + struct efivar_entry *var = container_of(kobj, struct efivar_entry,
    + kobj);
    kfree(var);
    }

    @@ -537,6 +535,9 @@ efivar_delete(struct subsystem *sub, const char *buf, size_t count)
    spin_unlock(&efivars_lock);
    return -EIO;
    }
    +
    + list_del(&search_efivar->list);
    +
    /* We need to release this lock before unregistering. */
    spin_unlock(&efivars_lock);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-01-22 17:09    [W:0.018 / U:0.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site