lkml.org 
[lkml]   [2007]   [Jan]   [2]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 2 Jan 2007 09:32:56 +0100
FromJens Axboe <>
SubjectRe: [PATCH 2.6.19] Adding branch to remove possible unnecessary inst
On Sun, Dec 31 2006, yc_zhou wrote:
> Function blk_queue_bounce_limit using dma flag to determine whether
> assigned a certain value for member of request_queue_t. But the
> assignment is unconditionally after the flag is set. It introduce
> possible unnecessary instructions.

Your patch is white space damaged, it makes it hard to read and
impossible to apply.

Note that blk_queue_bounce_limit() is an initialization function, so not
much gained from optimizing on that.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-02 09:35    [from the cache]
©2003-2008