lkml.org 
[lkml]   [2007]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] nfs: fix congestion control
    From
    Date
    On Wed, 2007-01-17 at 16:54 -0500, Trond Myklebust wrote:
    > On Wed, 2007-01-17 at 22:52 +0100, Peter Zijlstra wrote:
    >
    > > >
    > > > > Index: linux-2.6-git/fs/inode.c
    > > > > ===================================================================
    > > > > --- linux-2.6-git.orig/fs/inode.c 2007-01-12 08:03:47.000000000 +0100
    > > > > +++ linux-2.6-git/fs/inode.c 2007-01-12 08:53:26.000000000 +0100
    > > > > @@ -81,6 +81,7 @@ static struct hlist_head *inode_hashtabl
    > > > > * the i_state of an inode while it is in use..
    > > > > */
    > > > > DEFINE_SPINLOCK(inode_lock);
    > > > > +EXPORT_SYMBOL_GPL(inode_lock);
    > > >
    > > > Hmmm... Commits to all NFS servers will be globally serialized via the
    > > > inode_lock?
    > >
    > > Hmm, right, thats not good indeed, I can pull the call to
    > > nfs_commit_list() out of that loop.
    >
    > There is no reason to modify any of the commit stuff. Please just drop
    > that code.

    I though you agreed to flushing commit pages when hitting the dirty page
    limit.

    Or would you rather see a notifier chain from congestion_wait() calling
    into the various NFS mounts?

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-18 15:27    [W:4.667 / U:1.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site