Messages in this thread | | | Subject | Re: [PATCH] nfs: fix congestion control | From | Trond Myklebust <> | Date | Wed, 17 Jan 2007 16:54:46 -0500 |
| |
On Wed, 2007-01-17 at 22:52 +0100, Peter Zijlstra wrote:
> > > > > Index: linux-2.6-git/fs/inode.c > > > =================================================================== > > > --- linux-2.6-git.orig/fs/inode.c 2007-01-12 08:03:47.000000000 +0100 > > > +++ linux-2.6-git/fs/inode.c 2007-01-12 08:53:26.000000000 +0100 > > > @@ -81,6 +81,7 @@ static struct hlist_head *inode_hashtabl > > > * the i_state of an inode while it is in use.. > > > */ > > > DEFINE_SPINLOCK(inode_lock); > > > +EXPORT_SYMBOL_GPL(inode_lock); > > > > Hmmm... Commits to all NFS servers will be globally serialized via the > > inode_lock? > > Hmm, right, thats not good indeed, I can pull the call to > nfs_commit_list() out of that loop.
There is no reason to modify any of the commit stuff. Please just drop that code.
Trond
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |