lkml.org 
[lkml]   [2007]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: patch pci-rework-documentation-pci.txt.patch added to gregkh-2.6 tree
On Wed, Jan 17, 2007 at 10:09:08AM +0059, Jiri Slaby wrote:
> gregkh@suse.de wrote:
> [...]
> > +Tips on when/where to use the above attributes:
> > + o The module_init()/module_exit() functions (and all
> > + initialization functions called _only_ from these)
> > + should be marked __init/__exit.
> > +
> > + o Do not mark the struct pci_driver.
> > +
> > + o The ID table array should be marked __devinitdata.
>
> Is that correct? It panics somewehere IIRC?

If it's marked __initdata it can panic if we try to access the data when
adding a new PCI device after the system is up and running (pci hotplug
or dynamic pci ids support.) That's why it needs to be either no
marking or __devinitdata (which resolves to nothing if CONFIG_HOTPLUG is
enabled.)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-17 20:47    [W:0.056 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site