lkml.org 
[lkml]   [2007]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 53/59] sysctl: Remove support for CTL_ANY
    Date
    From: Eric W. Biederman <ebiederm@xmission.com> - unquoted

    There are currently no users in the kernel for CTL_ANY and it
    only has effect on the binary interface which is practically
    unused.

    So this complicates sysctl lookups for no good reason so just remove it.

    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    ---
    include/linux/sysctl.h | 1 -
    kernel/sysctl.c | 2 +-
    2 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
    index 63e1bac..c99e4bb 100644
    --- a/include/linux/sysctl.h
    +++ b/include/linux/sysctl.h
    @@ -53,7 +53,6 @@ struct __sysctl_args {

    /* For internal pattern-matching use only: */
    #ifdef __KERNEL__
    -#define CTL_ANY -1 /* Matches any name */
    #define CTL_NONE 0
    #define CTL_UNNUMBERED CTL_NONE /* sysctl without a binary number */
    #endif
    diff --git a/kernel/sysctl.c b/kernel/sysctl.c
    index 8da6647..e655b11 100644
    --- a/kernel/sysctl.c
    +++ b/kernel/sysctl.c
    @@ -1166,7 +1166,7 @@ repeat:
    for ( ; table->ctl_name || table->procname; table++) {
    if (!table->ctl_name)
    continue;
    - if (n == table->ctl_name || table->ctl_name == CTL_ANY) {
    + if (n == table->ctl_name) {
    int error;
    if (table->child) {
    if (ctl_perm(table, 001))
    --
    1.4.4.1.g278f
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-16 19:07    [W:2.423 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site