Messages in this thread |  | | | Date | Mon, 15 Jan 2007 09:16:02 +0200 | | Subject | Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros | | From | "Ahmed S. Darwish" <> |
| |
On Sun, Jan 14, 2007 at 09:37:21AM -0800, Arjan van de Ven wrote: > On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote: > > Substitue intel_rng magic PCI IDs values used in the IDs table > > with the macros defined in pci_ids.h > > > Hi, > > > hmm this is actually the opposite direction than most of the kernel is > heading in, mostly because the pci_ids.h file is a major maintenance > pain. > > Afaik the current "rule" is: if a PCI ID is only used in one driver, use > the numeric value and not (add) a symbolic constant.
I think you understood me wrong .. I haven't added new macros in pci_ids.h, I've just used the macros already defined there like the PCI_VENDOR_ID_INTEL and others.
-- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |