lkml.org 
[lkml]   [2007]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 20/20] XEN-paravirt: Add Xen virtual block device driver.

    On Jan 14 2007 13:24, Muli Ben-Yehuda wrote:
    >On Sun, Jan 14, 2007 at 12:05:13PM +0100, Jan Engelhardt wrote:
    >
    >> >+ (void)xenbus_switch_state(info->xbdev, XenbusStateConnected);
    >>
    >> Cast remove, if xenbus_switch_state does not have __must_check.
    >> Also elsewhere.
    >
    >Hmm, why? this way you know that the programmer isn't checking the
    >return value *on purpose*. More information is good.

    Then I'd prefer a comment. Plus, you don't do (void) on every
    xenbus_switch_state, so I have to assume (1) you either forgot to check the
    return value or (2) you don't follow your own "on purpose" policy. If you
    really want to enforce to use the return value and explicitly not in some
    places, then please tag it __must_check. http://lkml.org/lkml/2006/12/21/282
    might be something to read.


    -`J'
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-14 13:45    [W:0.024 / U:2.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site