Messages in this thread | | | Date | Mon, 15 Jan 2007 10:03:04 +0530 | From | Srivatsa Vaddagiri <> | Subject | Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist |
| |
On Mon, Jan 15, 2007 at 02:54:10AM +0300, Oleg Nesterov wrote: > How about the pseudo-code below?
Some quick comments:
- singlethread_cpu needs to be hotplug safe (broken currently)
- Any reason why cpu_populated_map is not modified on CPU_DEAD?
- I feel more comfortable if workqueue_cpu_callback were to take workqueue_mutex in LOCK_ACQ and release it in LOCK_RELEASE notifications. This will provide stable access to cpu_populated_map to functions like __create_workqueue.
Finally, I wonder if these changes will be unnecessary if we move to process freezer based hotplug locking ...
-- Regards, vatsa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |