[lkml]   [2007]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 18/19] ide: add ide_use_fast_pio() helper
    On 1/12/07, Alan <> wrote:
    > On Fri, 12 Jan 2007 05:28:00 +0100
    > Bartlomiej Zolnierkiewicz <> wrote:
    > > [PATCH] ide: add ide_use_fast_pio() helper
    > >
    > > * add ide_use_fast_pio() helper for use by host drivers
    > > * add DMA capability and autodma checks to ide_use_dma()
    > > - au1xxx-ide/it8213/it821x drivers didn't check for (id->capability & 1)
    > For the IT8211/2 in SMART this check shouldn't be made.

    It is OK since in it821x_fixups() we set it explicitly:

    if(strstr(id->model, "Integrated Technology Express")) {
    /* In raid mode the ident block is slightly buggy
    We need to set the bits so that the IDE layer knows
    LBA28. LBA48 and DMA ar valid */
    id->capability |= 3; /* LBA28, DMA */

    and we are better off using generic helper if we can
    (which may later allow us to use generic tuning code).

    > > - ide-cris driver didn't set ->autodma
    > You've changed the behaviour there. Should the default be autodma=0 ?

    Before my patch hwif->autodma was only checked in the chipset specific
    hwif->ide_dma_check implementations. For ide-cris it is
    function so there no behavior change here.

    Sorry for not explaining changes in detail in the patch description
    (I will update it).

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-01-12 15:21    [W:0.043 / U:4.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site