![]() | |||||||||||||
Messages in this thread |
Hello On Thursday 11 January 2007 04:00, Nick Piggin wrote: > Vladimir V. Saveliev wrote: > > Hello > > > > On Tuesday 09 January 2007 21:30, Linus Torvalds wrote: > > > >>On Tue, 9 Jan 2007, Malte Schröder wrote: > >> > >>>>So something interesting is definitely going on, but I don't know exactly > >>>>what it is. Why does reiserfs do the truncate as part of a close, if the > >>>>same inode is actually mapped somewhere else? > > > > > > on file close reiserfs tries to "pack" content of last incomplete page of file into metadata blocks. > > It should not if that page is still mapped somewhere. > > It does not actually truncate, it calls the same function which does truncate, but file size does not change. > > That's racy, unfortunately :P > Sorry, please, explain what is racy. reiserfs_truncate and reiserfs_release call that function after they have inode's mutex locked. > > > > Please consider the below patch. > > That seems like it would work. Probably papers over your truncate-inside-i_size as well. > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-01-11 14:25 [from the cache] ©2003-2008 | |||||||||||||