Messages in this thread | | | Date | Thu, 11 Jan 2007 13:49:04 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2.6.20-rc4 4/4][RFC] sys_futex64 : allows 64bit futexes |
| |
On Tue, 09 Jan 2007 17:25:26 +0100 Pierre Peiffer <pierre.peiffer@bull.net> wrote:
> static inline int > +futex_atomic_op_inuser64 (int encoded_op, u64 __user *uaddr)
Your email client performs space-stuffing. Please see if you can turn that off. (It's fixable at my end with s/^ /^/g but it's a nuisance).
> +{ > + int op = (encoded_op >> 28) & 7; > + int cmp = (encoded_op >> 24) & 15; > + u64 oparg = (encoded_op << 8) >> 20; > + u64 cmparg = (encoded_op << 20) >> 20; > + u64 oldval = 0, ret, tem; > + > + if (encoded_op & (FUTEX_OP_OPARG_SHIFT << 28)) > + oparg = 1 << oparg; > + > + if (! access_ok (VERIFY_WRITE, uaddr, sizeof(u64))) > + return -EFAULT; > + > + inc_preempt_count();
What is that open-coded, uncommented inc_preempt_count() doing in there? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |