![]() | |||||||||||||
Messages in this thread |
Hello! So you mean that in this particular case it's faster with a handcoded comparison than memcmp? Because both key1 and key2 are located at word-aligned addresses? That's fascinating. Best regards, Daniel 2006/12/31, David Miller <davem@davemloft.net>: > From: "Daniel_Marjamäki" <daniel.marjamaki@gmail.com> > Date: Sun, 31 Dec 2006 17:37:05 +0100 > > > From: Daniel Marjamäki > > This has been tested by me. > > Signed-off-by: Daniel Marjamäki <daniel.marjamaki@gmail.com> > > Please do not do this. > > memcmp() cannot assume the alignment of the source and > destination buffers and thus will run more slowly than > that open-coded comparison. > > That code was done like that on purpose because it is > one of the most critical paths in the networking flow > cache lookup which runs for every IPSEC packet going > throught the system. > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-01-01 07:51 [W:0.357 / U:0.230 seconds] ©2003-2008 Jasper Spaans | |||||||||||||